ConnectionExceptions thrown from Bugzilla.connectTo()#1
Open
Tmarks wants to merge 3 commits intoThorn1089:masterfrom
Tmarks:master
Open
ConnectionExceptions thrown from Bugzilla.connectTo()#1Tmarks wants to merge 3 commits intoThorn1089:masterfrom Tmarks:master
Tmarks wants to merge 3 commits intoThorn1089:masterfrom
Tmarks:master
Conversation
get latest
…zilla implementation. It belonged here because the BugzillaConnector throws it from its connectTo() methods, but the Bugzilla class did not. This was also changed; Bugzilla's connectTo() methods now throw ConnectionException in their signatures.
Owner
There was a problem hiding this comment.
When I first wrote the alpha for J2Bugzilla, I was solidly in the checked exception camp. Now I'm wondering if this ought to extend RuntimeException instead. On the one hand, it's nice to provide callers something specific to catch instead of plain old Exception; on the other hand, it depends if you really consider a low-level network problem of the type encountered by the connect methods to really be recoverable. I feel like RuntimeExceptions strike a slightly better balance of "Catch it if you want to be robust, let it fly if you want things to blow up loudly."
- *Finally* changed getName()'s visibility to public... - Fixed a comment on the constructor to say SearchBy instead of SearchLimiter. Must've been an old name. pom.xml: - Added dependency for xmlrpc-client. Bugzilla.java: - Removed throws declarations of ConnectionException from all methods, since... ConnectionException.java: - ... now extends RuntimeException. Bugzilla.java:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the ConnectionException class from the old j2bugzilla code, and made all overloads of Bugzilla.connectTo() throw this exception, just as the BugzillaConnector did.